Add mode for watching PID and exit if it dies #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage 94.20% 94.20%
=======================================
Files 22 22
Lines 2933 2933
=======================================
Hits 2763 2763
Misses 170 170 |
fasmat
approved these changes
Oct 26, 2023
4 tasks
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Oct 26, 2023
## Motivation In spacemeshos/post-rs#141 the post service was extended to shut down when a process with a given PID exits. This PR integrates the change. Merge after spacemeshos/post-rs#141 ## Changes - Update Post Supervisor to pass PID - Log errors in post supervisor instead of returning them ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Oct 26, 2023
## Motivation In spacemeshos/post-rs#141 the post service was extended to shut down when a process with a given PID exits. This PR integrates the change. Merge after spacemeshos/post-rs#141 ## Changes - Update Post Supervisor to pass PID - Log errors in post supervisor instead of returning them ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Oct 26, 2023
## Motivation In spacemeshos/post-rs#141 the post service was extended to shut down when a process with a given PID exits. This PR integrates the change. Merge after spacemeshos/post-rs#141 ## Changes - Update Post Supervisor to pass PID - Log errors in post supervisor instead of returning them ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Oct 26, 2023
## Motivation In spacemeshos/post-rs#141 the post service was extended to shut down when a process with a given PID exits. This PR integrates the change. Merge after spacemeshos/post-rs#141 ## Changes - Update Post Supervisor to pass PID - Log errors in post supervisor instead of returning them ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Oct 26, 2023
## Motivation In spacemeshos/post-rs#141 the post service was extended to shut down when a process with a given PID exits. This PR integrates the change. Merge after spacemeshos/post-rs#141 ## Changes - Update Post Supervisor to pass PID - Log errors in post supervisor instead of returning them ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Oct 26, 2023
## Motivation In spacemeshos/post-rs#141 the post service was extended to shut down when a process with a given PID exits. This PR integrates the change. Merge after spacemeshos/post-rs#141 ## Changes - Update Post Supervisor to pass PID - Log errors in post supervisor instead of returning them ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
--watch-pid=<PID>CLI argument. When passed, the post-service will watch this PID and quit when it's not alive.