Fix terminating watch_pid task #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=======================================
Coverage 93.88% 93.88%
=======================================
Files 24 24
Lines 3009 3009
=======================================
Hits 2825 2825
Misses 184 184 ☔ View full report in Codecov by Sentry. |
fasmat
approved these changes
Nov 24, 2023
|
I built it locally and tested it in spacemeshos/go-spacemesh#5300. It seems to work for linux, for Windows we need spacemeshos/post#249. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blocking task watching PID did not terminate when the
serviceclosed. Tokio cannot terminate a blocking task by itself - it needs to be signalled to do so.Added a one-shot termination channel that is passed to the blocking task. The task terminates when the channel is closed or it is sent any value.