Reduce service memory requirements by not keeping randomx all the time #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 93.68% 93.73% +0.04%
==========================================
Files 24 24
Lines 3026 3047 +21
==========================================
+ Hits 2835 2856 +21
Misses 191 191 ☔ View full report in Codecov by Sentry. |
pigmej
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't keep an instance of pow verifier (randomx) all the time in the service. Instead, it is re-created on demand (which is to verify the proof after it's finished). Initialization of randomx in light mode takes about ~300ms which is a reasonable tradeoff to save ~250MiB for the rest of the epoch.