Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCD-677/equal-weight-special-case #892

Conversation

alphasentaurii
Copy link
Collaborator

Resolves CCD-677 where some extended batch file submissions allowed more than one reference file to satisfy a given matching rule, potentially causing pipeline crashes. To prevent users from missing or ignoring this, the warning has been changed to an error (submission will not be completed).

@alphasentaurii alphasentaurii removed the request for review from stscieisenhamer July 29, 2022 00:43
Copy link
Collaborator

@stscieisenhamer stscieisenhamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the removal of commented code, LGTM

crds/core/selectors.py Outdated Show resolved Hide resolved
@alphasentaurii alphasentaurii merged commit f50288f into spacetelescope:master Aug 1, 2022
@alphasentaurii alphasentaurii deleted the ccd-677-equal-weight-special-case branch August 1, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants