Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCD-1214 roman-pipeline-autoconfirmation #904

Merged

Conversation

alphasentaurii
Copy link
Collaborator

Roman pipeline authorized user can pass the --autoconfirm argument to automatically confirm reference file submissions as long as there are no errors. If there are errors, the submission is automatically canceled.

Minor updates to the file_map attribute for submission api script (no longer need to run "update_file_map()" - the script will try to get the renamed mappings and references even if the submission has not yet been confirmed (i.e. pmaps and imaps not actually generated yet).

Copy link
Collaborator

@stscieisenhamer stscieisenhamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog and pr title imply this is roman only, but it is not clear that is the case?

Also, there was a request for making this restricted in other ways? Is there any of that. IMHO this needs no restrictions. However, if there are, what are they?

@alphasentaurii
Copy link
Collaborator Author

The changelog and pr title imply this is roman only, but it is not clear that is the case?

Also, there was a request for making this restricted in other ways? Is there any of that. IMHO this needs no restrictions. However, if there are, what are they?

Restricted auth is handled on the server side, I created a PR for that as well. So, it is Roman-only in the sense that currently the only user with sufficient permissions for the --autoconfirm option is the roman pipeline user. (not including superusers)

@alphasentaurii alphasentaurii merged commit 9dda6fd into spacetelescope:master Oct 20, 2022
@alphasentaurii alphasentaurii deleted the confirm-submission branch March 7, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants