HLA-1427: Improve algorithm for switching to crowded field kernel for HAP segment catalogs #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segment as a discriminant with regard to switching from a Gaussian to a Ricker-Wavelet kernel. The kernel is used to convolve with the input image to increase the signal-to-noise ratio for the detection of faint sources.
mdlpstsci
force-pushed
the
crowdedFieldKernel
branch
from
d387dbd to
22d9fa9
Compare
rlwastro
approved these changes
Feb 20, 2025
Co-authored-by: Rick White <rlw@stsci.edu>
rlwastro
reviewed
Feb 20, 2025
drizzlepac/haputils/catalog_utils.py
Outdated
| @@ -2846,6 +2846,7 @@ def _evaluate_segmentation_image(self, segm_img, image_data, big_island_only=Fal | |||
| real_pixels = (np.isfinite(image_data) & (image_data != 0)).sum().clip(min=1) | |||
| biggest_source = segm_img.areas.max()/real_pixels | |||
There was a problem hiding this comment.
Need to delete the redundant definition of biggest_source on line 2847. It is replaced by new line 2849.
There was a problem hiding this comment.
This is what I get for just accepting the change via the GUI which I basically never do - except for this time!
There was a problem hiding this comment.
I'm sure I could have marked it up correctly in the GUI so it was OK to accept the change! So it is my fault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves HLA-1427
Closes #
Added a third test using the size in pixels of the largest determined segment as a discriminant with regard to switching from a Gaussian to a Ricker-Wavelet kernel. The kernel is used to convolve with the input image to increase the signal-to-noise ratio for the detection of faint sources.
Checklist for maintainers
CHANGELOG.rstwithin the relevant release section