Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix jwst downstream toxenv with py310 #470

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Aug 16, 2023

See: spacetelescope/roman_datamodels#261 for more details

In brief, tox updated, because test-jwst-cov-xdist env is not listed in tox.ini and not prefixed with pyxx it no longer works. This PR prefixes it with py310 to run with python 3.10.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (77d0b01) 87.23% compared to head (2d53b64) 87.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #470   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files          23       23           
  Lines        3816     3816           
=======================================
  Hits         3329     3329           
  Misses        487      487           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review August 16, 2023 21:50
@braingram braingram requested a review from a team as a code owner August 16, 2023 21:50
@braingram
Copy link
Collaborator Author

The failure in the py310-test-jwst-cov-xdist job appears unrelated to the changes in this PR. In this PR the job actually ran, whereas without the changes in this PR the job fails to start as seen:
https://github.com/spacetelescope/gwcs/actions/runs/5882935001/job/15954514200?pr=469#step:10:17

@nden nden merged commit 11a94af into spacetelescope:master Aug 21, 2023
@braingram braingram deleted the tox_fixes branch August 21, 2023 12:35
@nden nden added this to the 0.19 milestone Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants