Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integer rounding to match APE 14 #525

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

WilliamJamieson
Copy link
Collaborator

Fixes #524

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner November 12, 2024 19:11
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.44%. Comparing base (9cd8552) to head (6cfcc53).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
gwcs/api.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
+ Coverage   87.42%   87.44%   +0.01%     
==========================================
  Files          22       22              
  Lines        3874     3888      +14     
==========================================
+ Hits         3387     3400      +13     
- Misses        487      488       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamJamieson WilliamJamieson force-pushed the bugfix/integer_rounding branch 2 times, most recently from 6989eba to 124b669 Compare November 15, 2024 15:36
@nden nden added this to the 0.22 milestone Dec 2, 2024
@WilliamJamieson WilliamJamieson force-pushed the bugfix/integer_rounding branch from 3b30fc5 to 262ee74 Compare December 2, 2024 18:04
@nden nden merged commit c01c6d0 into spacetelescope:master Dec 2, 2024
24 of 25 checks passed
@WilliamJamieson WilliamJamieson deleted the bugfix/integer_rounding branch December 2, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

world_to_array_index_values does not round to integers as APE 14 and astropy.wcs indicate it should
2 participants