Skip to content

Commit

Permalink
xfail roundtrip bug for fake GWCS
Browse files Browse the repository at this point in the history
  • Loading branch information
pllim committed Feb 27, 2024
1 parent 63b460b commit 0336005
Showing 1 changed file with 12 additions and 6 deletions.
18 changes: 12 additions & 6 deletions jdaviz/configs/imviz/tests/test_orientation.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,12 @@ def test_markers_plugin_recompute_positions_pixels_to_wcs(self):

# Both marks stay the same in sky, so this means X and Y w.r.t. reference
# same on both entries.
# 0.25 offset probably introduced by fake WCS layer.
assert_allclose(mp._obj.marks["imviz-0"].x, -0.25)
assert_allclose(mp._obj.marks["imviz-0"].y, -0.25)
# FIXME: 0.25 offset introduced by fake WCS layer (remove AssertionError).
# https://jira.stsci.edu/browse/JDAT-4256
with pytest.raises(AssertionError):
assert_allclose(mp._obj.marks["imviz-0"].x, 0)
with pytest.raises(AssertionError):
assert_allclose(mp._obj.marks["imviz-0"].y, 0)

mp.clear_table()

Expand Down Expand Up @@ -102,9 +105,12 @@ def test_markers_plugin_recompute_positions_wcs_to_pixels(self):

# Both marks now get separated, so this means X and Y w.r.t. reference
# are different on both entries.
# 0.25 offset probably introduced by fake WCS layer.
assert_allclose(mp._obj.marks["imviz-0"].x, [1.25, 0.25])
assert_allclose(mp._obj.marks["imviz-0"].y, 0.25)
# FIXME: 0.25 offset introduced by fake WCS layer (remove AssertionError).
# https://jira.stsci.edu/browse/JDAT-4256
with pytest.raises(AssertionError):
assert_allclose(mp._obj.marks["imviz-0"].x, [1, 0])
with pytest.raises(AssertionError):
assert_allclose(mp._obj.marks["imviz-0"].y, 0)

mp.clear_table()

Expand Down

0 comments on commit 0336005

Please sign in to comment.