Use existing traitlet for check

Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
spacetelescope · Jul 12, 2023 · 388430c · 388430c
1 parent 0c24d99
commit 388430c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/jdaviz/configs/specviz/plugins/line_analysis/line_analysis.py b/jdaviz/configs/specviz/plugins/line_analysis/line_analysis.py
@@ -115,7 +115,6 @@ class LineAnalysis(PluginTemplateMixin, DatasetSelectMixin, SpectralSubsetSelect
     identified_line = Unicode("").tag(sync=True)
     selected_line = Unicode("").tag(sync=True)
     selected_line_redshift = Float(0).tag(sync=True)
-    lines_loaded = Bool(False).tag(sync=True)
 
     def __init__(self, *args, **kwargs):
 
@@ -287,7 +286,6 @@ def get_results(self):
         return self.results
 
     def _on_plotted_lines_changed(self, msg):
-        self.lines_loaded = True if len(msg.marks) > 0 else False
         self.line_marks = msg.marks
         self.line_items = msg.names_rest
         if self.selected_line not in self.line_items:

diff --git a/jdaviz/configs/specviz/plugins/line_analysis/line_analysis.vue b/jdaviz/configs/specviz/plugins/line_analysis/line_analysis.vue
@@ -133,7 +133,7 @@
         ></v-progress-circular>
       </div>
 
-      <div v-if="lines_loaded">
+      <div v-if="line_items.length > 0">
         <j-plugin-section-header>Redshift from Centroid</j-plugin-section-header>
         <v-row>
           <j-docs-link>Assign the centroid reported above to the observed wavelength of a given line and set the resulting redshift.  Lines must be loaded and plotted through the Line Lists plugin first.</j-docs-link>