Skip to content

Commit

Permalink
drop support for Python 3.8
Browse files Browse the repository at this point in the history
  • Loading branch information
zacharyburnett committed Apr 14, 2023
1 parent 6a2892c commit 4f72adb
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci_workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ jobs:
toxenv: py39-test
allow_failure: false

- name: Windows - Python 3.8
- name: Windows - Python 3.9
os: windows-latest
python: 3.8
toxenv: py38-test
python: 3.9
toxenv: py39-test
allow_failure: false

# This also runs on cron but we want to make sure new changes
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:

- uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.9

- name: Install python-build and twine
run: python -m pip install build "twine>=3.3"
Expand Down
2 changes: 2 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ Specviz2d
Other Changes and Additions
---------------------------

- drop support for Python 3.8 [#2152]

3.4.1 (unreleased)
==================

Expand Down
2 changes: 1 addition & 1 deletion docs/installation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Common Issues
If you encounter problems while following these installation instructions,
please consult :ref:`known installation issues <known_issues_installation>`.

Note that ``jdaviz`` requires Python 3.8 or newer. If your ``pip`` corresponds to an older version of
Note that ``jdaviz`` requires Python 3.9 or newer. If your ``pip`` corresponds to an older version of
Python, it will raise an error that it cannot find a valid package.

Users occasionally encounter problems running the pure ``pip`` install above. For those
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ github_project = spacetelescope/jdaviz
zip_safe = False
packages = find:
include_package_data = True
python_requires = >=3.8
python_requires = >=3.9
setup_requires = setuptools_scm
install_requires =
packaging
Expand Down

0 comments on commit 4f72adb

Please sign in to comment.