Skip to content

Commit

Permalink
Merge pull request #3290 from pllim/revert-ignore-gwcs-warn
Browse files Browse the repository at this point in the history
Un-ignore GWCS warning because it is no longer necessary
  • Loading branch information
pllim authored Dec 9, 2024
2 parents 527d1f5 + 85caeaa commit 6c946d3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
6 changes: 1 addition & 5 deletions jdaviz/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -856,11 +856,7 @@ def load_data(self, file_obj, parser_reference=None, **kwargs):
parser = data_parser_registry.members.get(data_parser)

if parser is not None:
with warnings.catch_warnings():
# https://github.com/spacetelescope/gwcs/pull/522
warnings.filterwarnings(
"ignore", message="The bounding_box was set in C order.*")
parser(self, file_obj, **kwargs)
parser(self, file_obj, **kwargs)
else:
self._application_handler.load_data(file_obj)

Expand Down
7 changes: 1 addition & 6 deletions jdaviz/configs/mosviz/tests/test_parsers.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import warnings
from zipfile import ZipFile

import pytest
Expand Down Expand Up @@ -146,11 +145,7 @@ def test_niriss_parser(mosviz_helper, tmp_path):
imview = mosviz_helper.app.get_viewer(mosviz_helper._default_image_viewer_reference_name)
x_pixcenter = (imview.state.x_max + imview.state.x_min)/2.0
y_pixcenter = (imview.state.y_max + imview.state.y_min)/2.0
with warnings.catch_warnings():
# https://github.com/spacetelescope/gwcs/pull/522
warnings.filterwarnings(
"ignore", message="The bounding_box was set in C order.*")
viewer_center_coord = imview.layers[0].layer.coords.pixel_to_world(x_pixcenter, y_pixcenter)
viewer_center_coord = imview.layers[0].layer.coords.pixel_to_world(x_pixcenter, y_pixcenter)
assert_allclose(viewer_center_coord.ra.deg, dc_tab["R.A."][0])
assert_allclose(viewer_center_coord.dec.deg, dc_tab["Dec."][0])

Expand Down

0 comments on commit 6c946d3

Please sign in to comment.