fix: support for notebook 7

Notebook 7 requires a different way to detect if the app runs in a notebook context.
spacetelescope · Sep 4, 2023 · e9906ea · e9906ea
1 parent 1577249
commit e9906ea
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -109,6 +109,8 @@ Bug Fixes
 
 - Fixes tracebacks from plugins opened in popout windows. [#2411]
 
+- Fixes app not displaying properly in Notebook 7. [#2420]
+
 Cubeviz
 ^^^^^^^
 

diff --git a/jdaviz/app.vue b/jdaviz/app.vue
@@ -167,7 +167,8 @@ export default {
   methods: {
     checkNotebookContext() {
       this.notebook_context = document.getElementById("ipython-main-app")
-        || document.querySelector('.jp-LabShell');
+        || document.querySelector('.jp-LabShell')
+        || document.querySelector(".lm-Widget#main"); /* Notebook 7 */
       return this.notebook_context;
     },
     trayItemVisible(trayItem, tray_items_filter) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -109,6 +109,8 @@ Bug Fixes @@
     - Fixes tracebacks from plugins opened in popout windows. [#2411]
+    - Fixes app not displaying properly in Notebook 7. [#2420]
     Cubeviz
     ^^^^^^^
@@ Expand Down @@