Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Pin tox<4 #1901

Merged
merged 1 commit into from
Dec 7, 2022
Merged

TST: Pin tox<4 #1901

merged 1 commit into from
Dec 7, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Dec 7, 2022

Description

Pin tox<4 because it has breaking change. See tox-dev/tox#2612

  • After merge, open up follow-up issue to unpin in the future when we can.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

because it has breaking change
@pllim pllim added testing 🔥 Critical trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤backport-v3.1.x on-merge: backport to v3.1.x labels Dec 7, 2022
@pllim pllim added this to the 3.1.2 milestone Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 88.48% // Head: 88.48% // No change to project coverage 👍

Coverage data is based on head (95d637b) compared to base (01f868c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1901   +/-   ##
=======================================
  Coverage   88.48%   88.48%           
=======================================
  Files          95       95           
  Lines       10540    10540           
=======================================
  Hits         9326     9326           
  Misses       1214     1214           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim pllim marked this pull request as ready for review December 7, 2022 20:27
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me to get PR CIs running again until the fix upstream gets in!

@pllim pllim merged commit f36f3b2 into spacetelescope:main Dec 7, 2022
@pllim pllim deleted the pin-tox branch December 7, 2022 20:39
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Dec 7, 2022
pllim added a commit that referenced this pull request Dec 7, 2022
…1-on-v3.1.x

Backport PR #1901 on branch v3.1.x (TST: Pin tox<4)
kecnry pushed a commit to kecnry/jdaviz that referenced this pull request Dec 8, 2022
@kecnry kecnry mentioned this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Critical no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two 💤backport-v3.1.x on-merge: backport to v3.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants