Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: glue-jupyter PR 343 #1963

Closed
wants to merge 1 commit into from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jan 17, 2023

Description

Test glue-viz/glue-jupyter#343

xref #1961

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Base: 91.86% // Head: 91.86% // No change to project coverage 👍

Coverage data is based on head (9bf1bb5) compared to base (c0b5cd0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1963   +/-   ##
=======================================
  Coverage   91.86%   91.86%           
=======================================
  Files         140      140           
  Lines       15069    15069           
=======================================
  Hits        13843    13843           
  Misses       1226     1226           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim
Copy link
Contributor Author

pllim commented Jan 17, 2023

Ugh jupyter_client/session.py too?

Update: Someone fixed it in jupyter/jupyter_client#915

@pllim pllim closed this Jan 18, 2023
@pllim pllim deleted the tst-gj-pr343 branch January 18, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant