Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Ignore ioloop DeprecationWarning from pyzmq #1965

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jan 18, 2023

Description

This pull request is to ignore ioloop DeprecationWarning from pyzmq because it comes from at least 3 upstream packages. We do not call this.

Relevant upstream PRs:

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

from pyzmq because it comes from at least 3 upstream packages.
@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤 backport-v3.2.x on-merge: backport to v3.2.x labels Jan 18, 2023
@pllim pllim added this to the 3.2.1 milestone Jan 18, 2023
@pllim pllim marked this pull request as ready for review January 18, 2023 21:57
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 91.86% // Head: 91.86% // No change to project coverage 👍

Coverage data is based on head (c7a8023) compared to base (c0b5cd0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1965   +/-   ##
=======================================
  Coverage   91.86%   91.86%           
=======================================
  Files         140      140           
  Lines       15069    15069           
=======================================
  Hits        13843    13843           
  Misses       1226     1226           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim
Copy link
Contributor Author

pllim commented Jan 19, 2023

dev failures now unrelated to pyzmq . Merging this so we can deal with the real failures as follow up. See #1967

@pllim pllim merged commit c1c601a into spacetelescope:main Jan 19, 2023
@pllim pllim deleted the ignore-zmq-depre branch January 19, 2023 01:03
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Jan 19, 2023
pllim added a commit that referenced this pull request Jan 19, 2023
…5-on-v3.2.x

Backport PR #1965 on branch v3.2.x (TST: Ignore ioloop DeprecationWarning from pyzmq)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two 💤 backport-v3.2.x on-merge: backport to v3.2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant