Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin glue-astronomy maxversion #1975

Closed
wants to merge 1 commit into from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jan 23, 2023

Description

Pin glue-astronomy maxversion to see if it makes #1974 go away.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added the no-changelog-entry-needed changelog bot directive label Jan 23, 2023
@pllim pllim added this to the 3.2.1 milestone Jan 23, 2023
@pllim pllim added Upstream fix required trivial Only needs one approval instead of two 💤 backport-v3.2.x on-merge: backport to v3.2.x labels Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 91.93% // Head: 91.93% // No change to project coverage 👍

Coverage data is based on head (5f8bc5a) compared to base (8f8106b).
Patch has no changes to coverable lines.

❗ Current head 5f8bc5a differs from pull request most recent head aa59535. Consider uploading reports for the commit aa59535 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1975   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files         140      140           
  Lines       15310    15310           
=======================================
  Hits        14076    14076           
  Misses       1234     1234           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

because glue-astronomy v0.6.0 requires a yet
unreleased version of glue-core.

Disable testing of dev glue-core and
dev glue-astronomy for now.
@pllim pllim force-pushed the pin-glue-astronomy branch from 5f8bc5a to aa59535 Compare January 23, 2023 21:48
@pllim pllim marked this pull request as ready for review January 23, 2023 22:16
@pllim
Copy link
Contributor Author

pllim commented Jan 23, 2023

CI passed here.

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's get this in for now as long as we have a follow-up issue/ticket to revert the pin as soon as upstream fixes are in. EDIT: I see that is being tracked in #1974. I also see that the glue-core release should be out soon, so if you think it makes sense to just wait, that's fine too)

@pllim
Copy link
Contributor Author

pllim commented Jan 24, 2023

But @astrofrog is already doing a glue-core release as we speak.

@pllim
Copy link
Contributor Author

pllim commented Jan 24, 2023

glue-core 1.6.1 is released this morning, so we no longer need to pin maxversion.

@pllim pllim closed this Jan 24, 2023
@pllim pllim deleted the pin-glue-astronomy branch January 24, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two Upstream fix required 💤 backport-v3.2.x on-merge: backport to v3.2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants