-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin glue-astronomy maxversion #1975
Conversation
Codecov ReportBase: 91.93% // Head: 91.93% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1975 +/- ##
=======================================
Coverage 91.93% 91.93%
=======================================
Files 140 140
Lines 15310 15310
=======================================
Hits 14076 14076
Misses 1234 1234 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
because glue-astronomy v0.6.0 requires a yet unreleased version of glue-core. Disable testing of dev glue-core and dev glue-astronomy for now.
5f8bc5a
to
aa59535
Compare
CI passed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Let's get this in for now as long as we have a follow-up issue/ticket to revert the pin as soon as upstream fixes are in. EDIT: I see that is being tracked in #1974. I also see that the glue-core release should be out soon, so if you think it makes sense to just wait, that's fine too)
But @astrofrog is already doing a glue-core release as we speak. |
glue-core 1.6.1 is released this morning, so we no longer need to pin maxversion. |
Description
Pin glue-astronomy maxversion to see if it makes #1974 go away.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.