Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Adding Plot Options toggle for mouseover info/marker #1986

Closed
wants to merge 1 commit into from

Conversation

bmorris3
Copy link
Contributor

Description

Originally implemented as a PR on top of #1894 (pllim#9), the commit in this PR (to main) allows users to see or hide the mouseover marker and info, by adding a toggle in the "Settings" dropdown in the Plot Options plugin:

JDAT-3038.mov

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

🐱

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 91.94% // Head: 91.94% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (971ce19) compared to base (ee804ea).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1986      +/-   ##
==========================================
- Coverage   91.94%   91.94%   -0.01%     
==========================================
  Files         140      140              
  Lines       15315    15321       +6     
==========================================
+ Hits        14082    14087       +5     
- Misses       1233     1234       +1     
Impacted Files Coverage Δ
jdaviz/app.py 94.41% <ø> (ø)
jdaviz/configs/specviz/plugins/viewers.py 85.95% <66.66%> (-0.17%) ⬇️
...nfigs/default/plugins/plot_options/plot_options.py 98.10% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim pllim added this to the 3.3 milestone Feb 3, 2023
@pllim
Copy link
Contributor

pllim commented Feb 3, 2023

Where does this PR stand now? Were we waiting for UI/UX advise? Were we waiting for PO feedback? Is this still relevant if we have to move the mouseover info somewhere else?

@bmorris3
Copy link
Contributor Author

bmorris3 commented Feb 6, 2023

Where does this PR stand now?

I'm not sure, @pllim. @camipacifici?

@kecnry
Copy link
Member

kecnry commented Feb 6, 2023

Where does this PR stand now?

I had left a number of comments on the original PR that I think still stand.

@rosteen rosteen modified the milestones: 3.3, 3.4 Feb 9, 2023
@kecnry kecnry mentioned this pull request Feb 14, 2023
32 tasks
@kecnry
Copy link
Member

kecnry commented Feb 14, 2023

See #1953 for a proposed migration of this logic into the markers plugin integration within the mouseover display.

Screen.Recording.2023-02-14.at.9.49.36.AM.mov

@kecnry kecnry closed this in #1953 Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants