Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use OpenAstronomy reusable workflow #2160

Closed

Conversation

zacharyburnett
Copy link
Contributor

@zacharyburnett zacharyburnett commented Apr 21, 2023

Description

This pull request uses the OpenAstronomy reusable workflow to run the tox environments; the advantage of using a reusable workflow is that it can be updated separately (to apply actions updates and the like) without changing this repo. The OpenAstronomy workflows are actively maintained.

image

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c0e2ed5) 91.50% compared to head (4397bd7) 91.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2160   +/-   ##
=======================================
  Coverage   91.50%   91.50%           
=======================================
  Files         147      147           
  Lines       16142    16142           
=======================================
  Hits        14771    14771           
  Misses       1371     1371           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett
Copy link
Contributor Author

zacharyburnett commented Apr 24, 2023

Required Status Checks in the branch protections (Settings -> Branches -> Branch Protections -> main) would also need to be updated with the new job names (just the testenv names):

  • Code style checks -> check / codestyle
  • OS X - Python 3.9 -> test / py39-test (macos-latest)
  • PEP517 -> check / pep517
  • Python 3.10 with coverage checking, all deps, and remote data -> test / py310-test-alldeps-cov (ubuntu-latest)
  • Security audit -> check / securityaudit
  • Windows - Python 3.8 -> test / py38-test (windows-latest) (will change after drop support for Python 3.8 #2152)

@rosteen
Copy link
Collaborator

rosteen commented May 2, 2023

Thanks for this contribution. After some offline discussion, we've decided that we would prefer to stick with our current CI setup for Jdaviz rather than moving to the OpenAstronomy workflows, but we can always reopen this PR later if we decide to move in that direction. For now, I'll close this.

@rosteen rosteen closed this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants