Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about python 3.8 and remove ipython pin #2177

Merged
merged 1 commit into from
May 2, 2023

Conversation

rosteen
Copy link
Collaborator

@rosteen rosteen commented May 2, 2023

As of #2152 , we no longer support python 3.8. This adds a warning to the home page of the docs, and drops a pin that was only needed because of 3.8 support.

@rosteen rosteen added documentation Explanation of code and concepts trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels May 2, 2023
@rosteen rosteen added this to the 3.5 milestone May 2, 2023
@rosteen
Copy link
Collaborator Author

rosteen commented May 2, 2023

Test failure looks like an unrelated timeout.

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5c794f3) 91.75% compared to head (4b72cd3) 91.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2177   +/-   ##
=======================================
  Coverage   91.75%   91.75%           
=======================================
  Files         147      147           
  Lines       16186    16186           
=======================================
  Hits        14852    14852           
  Misses       1334     1334           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@haticekaratay haticekaratay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rosteen rosteen merged commit 09dfd85 into spacetelescope:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Explanation of code and concepts no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants