Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Change PIP_EXTRA_INDEX_URL #2231

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jun 1, 2023

Description

Change PIP_EXTRA_INDEX_URL because packages moved where they upload nightly builds. This is one of the things they did at Scientific Python Developers Summit 2023.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

because packages moved where they upload nightly builds.
@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤 backport-v3.5.x on-merge: backport to v3.5.x labels Jun 1, 2023
@pllim pllim added this to the 3.5.1 milestone Jun 1, 2023
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dad1bd9) 91.59% compared to head (8169a6d) 91.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2231   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         148      148           
  Lines       16496    16496           
=======================================
  Hits        15110    15110           
  Misses       1386     1386           
Impacted Files Coverage Δ
jdaviz/configs/cubeviz/helper.py 98.87% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim pllim marked this pull request as ready for review June 1, 2023 01:29
@kecnry kecnry merged commit bd488f8 into spacetelescope:main Jun 1, 2023
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Jun 1, 2023
kecnry added a commit that referenced this pull request Jun 1, 2023
…1-on-v3.5.x

Backport PR #2231 on branch v3.5.x (TST: Change PIP_EXTRA_INDEX_URL)
@pllim pllim deleted the scientific-python-nightlies branch June 1, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two 💤 backport-v3.5.x on-merge: backport to v3.5.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants