Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jdaviz Launcher #2257
Jdaviz Launcher #2257
Changes from all commits
d3d2513
cefb486
e652be8
f3bb66d
dff234b
ceb79b0
b980750
bfa8a41
73c4b6f
0df09d9
507a528
47b50a5
0cd7a80
294c8d6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this definitely deserves to be quite "loud" in the change log entry as it technically is a breaking change to the CLI.
Discussed offline: after the launcher is more finalized and ready for public use, we might want to update the docs to suggest
jdaviz filename
directly and only keeping--layout
as advanced functionality. But that can (and should) be deferred.