Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Centroid Redshift when lines aren't loaded #2294

Merged
merged 4 commits into from
Jul 12, 2023

Conversation

duytnguyendtn
Copy link
Collaborator

@duytnguyendtn duytnguyendtn commented Jul 11, 2023

Description

This PR incorporates user feedback that the Redshfit from Centroid section from the Line Analysis plugin should only be shown if lines are actually plotted.

Because this is a UI element, coverage is expected to decrease

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@duytnguyendtn duytnguyendtn marked this pull request as ready for review July 11, 2023 22:05
@duytnguyendtn duytnguyendtn added this to the 3.6 milestone Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 76.55% and project coverage change: +0.01 🎉

Comparison is base (d261e71) 90.91% compared to head (388430c) 90.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2294      +/-   ##
==========================================
+ Coverage   90.91%   90.92%   +0.01%     
==========================================
  Files         152      152              
  Lines       17028    17115      +87     
==========================================
+ Hits        15481    15562      +81     
- Misses       1547     1553       +6     
Impacted Files Coverage Δ
...igs/default/plugins/model_fitting/model_fitting.py 86.45% <ø> (ø)
...imviz/plugins/aper_phot_simple/aper_phot_simple.py 92.66% <ø> (ø)
...igs/specviz/plugins/line_analysis/line_analysis.py 97.05% <ø> (ø)
jdaviz/core/data_formats.py 76.53% <33.33%> (-1.85%) ⬇️
jdaviz/core/launcher.py 35.18% <37.50%> (+19.56%) ⬆️
jdaviz/cli.py 27.90% <50.00%> (+0.84%) ⬆️
jdaviz/__init__.py 88.23% <100.00%> (ø)
jdaviz/components/toolbar_nested.py 85.00% <100.00%> (+11.31%) ⬆️
jdaviz/configs/imviz/plugins/tools.py 92.72% <100.00%> (+0.13%) ⬆️
...daviz/configs/imviz/tests/test_simple_aper_phot.py 100.00% <100.00%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
@duytnguyendtn duytnguyendtn requested a review from kecnry July 12, 2023 15:01
@duytnguyendtn duytnguyendtn added the trivial Only needs one approval instead of two label Jul 12, 2023
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks!

@duytnguyendtn duytnguyendtn merged commit b18ed7f into spacetelescope:main Jul 12, 2023
@duytnguyendtn duytnguyendtn deleted the HideAssign branch July 12, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
specviz trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants