Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook interactions to spec1d cubeviz example #23

Merged

Conversation

eteq
Copy link
Contributor

@eteq eteq commented May 30, 2019

This adjusts the cubeviz notebook and some of the corresponding code to demo using the notebook idiom to combine an "interactive" and "notebook" usage.

  1. It fixes up the units from the original data file to be in angstroms. To do this I had to do a slightly hacky thing in the cubeviz initializer, but I think it's probably fine as a stand-in. Moving forward we'll probably want to instead allow passing in data objects instead of names, but this seemed the fastest route forward. Note @brechmos-stsci - if you want to keep using the "fixed" file, you could just delete the process_data part and I presume it'll be the same
  2. It adds some analysis using specutils at the bottom of the notebook.
  3. it renames getRegions to get_regions since that's now showcased in the notebook

The last cell is meant to be used with the interactive selection in the profile viewer. I.e., it's just empty unless the user selects something in the profile view.

@brechmos-stsci
Copy link
Contributor

Basically worked, but the last cell still has getRegion rather than get_region. Could you change that and then I'll commit this.

@brechmos-stsci brechmos-stsci merged commit f096928 into spacetelescope:master Jun 4, 2019
james-trayford pushed a commit to james-trayford/jdaviz that referenced this pull request Dec 13, 2024
…mergechanges

Jt listener pre merge changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants