Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram bin size and limits #2309

Merged

Conversation

javerbukh
Copy link
Contributor

@javerbukh javerbukh commented Jul 25, 2023

Description

This pull request is to address point 3 in this comment #2097 (comment)
Before:
image

After:
image

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Add option to set bin size in plot options plugin and API call to change histogram viewer limits. [#2309]

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

Add option to set histogram bin size and API for viewer limits
@javerbukh javerbukh force-pushed the histogram-bin-size-and-limits branch from f2c94a7 to fc48234 Compare July 25, 2023 16:32
@javerbukh javerbukh added this to the 3.6 milestone Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 97.43% and project coverage change: +0.01% 🎉

Comparison is base (0b268b9) 90.97% compared to head (6125155) 90.99%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2309      +/-   ##
==========================================
+ Coverage   90.97%   90.99%   +0.01%     
==========================================
  Files         152      152              
  Lines       17282    17316      +34     
==========================================
+ Hits        15723    15756      +33     
- Misses       1559     1560       +1     
Files Changed Coverage Δ
...nfigs/default/plugins/plot_options/plot_options.py 94.33% <96.42%> (+0.14%) ⬆️
...lt/plugins/plot_options/tests/test_plot_options.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stretch_hist_nbins could be added to the user-API (and docstring) so its accessible from the plugin API.

@javerbukh javerbukh requested a review from kecnry July 26, 2023 17:22
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment, but otherwise looks good to me. Once merged, I'll open the PR to refactor the histogram to use the re-usable plugin component. Thanks!

Copy link
Collaborator

@duytnguyendtn duytnguyendtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behaves as expected; thanks!

@javerbukh javerbukh merged commit e078a91 into spacetelescope:main Jul 27, 2023
@javerbukh javerbukh mentioned this pull request Jul 27, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants