-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Histogram bin size and limits #2309
Histogram bin size and limits #2309
Conversation
Add option to set histogram bin size and API for viewer limits
f2c94a7
to
fc48234
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2309 +/- ##
==========================================
+ Coverage 90.97% 90.99% +0.01%
==========================================
Files 152 152
Lines 17282 17316 +34
==========================================
+ Hits 15723 15756 +33
- Misses 1559 1560 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stretch_hist_nbins
could be added to the user-API (and docstring) so its accessible from the plugin API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment, but otherwise looks good to me. Once merged, I'll open the PR to refactor the histogram to use the re-usable plugin component. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Behaves as expected; thanks!
Description
This pull request is to address point 3 in this comment #2097 (comment)
Before:
After:
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Add option to set bin size in plot options plugin and API call to change histogram viewer limits. [#2309]
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.