-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: glue-jupyter compatibility for import #2336
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2336 +/- ##
=======================================
Coverage ? 90.53%
=======================================
Files ? 152
Lines ? 17370
Branches ? 0
=======================================
Hits ? 15726
Misses ? 1644
Partials ? 0
☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
25d5738
to
3a87403
Compare
3a87403
to
2956f06
Compare
Should be uncontroversial. Nothing we can do about this anyway. Friday night YOLO! |
This comment was marked as resolved.
This comment was marked as resolved.
…nged MNT: glue-jupyter compatibility for import (cherry picked from commit d731eb3)
Description
Blocked by:
MNT: glue-jupyter compatibility for import for glue-viz/glue-jupyter#379 . If we end up needing to bump minversion of glue-jupyter to 0.18 anyway for other reasons, then we do not need the compatibility layer and can just switch straight to new import.
TST: Temporarily ignore DeprecationWarning from astropy/numpy dev that is already fixed in astropy/astropy#15116 . This should go away on its own when astropy uploads new dev wheel and then we can remove the ignore added here. I just need this out of the way to see if we get all the glue-jupyter stuff.TST: Use legacy numpy print option so we don't have to deal with the new print, yet.Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.