Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Use tmp_path in test_autoconfig #2481

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Sep 27, 2023

Description

Noticed this while working on something else (#2431). No reason to roll our own temporary directory here. Must have slipped past PR review stage.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added bug Something isn't working testing trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤 backport-v3.7.x on-merge: backport to v3.7.x labels Sep 27, 2023
@pllim pllim added this to the 3.7.1 milestone Sep 27, 2023
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pllim pllim merged commit ab9627c into spacetelescope:main Sep 27, 2023
@pllim pllim deleted the autoconfig-tmppath branch September 27, 2023 16:43
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Sep 27, 2023
pllim added a commit that referenced this pull request Sep 27, 2023
…1-on-v3.7.x

Backport PR #2481 on branch v3.7.x (TST: Use tmp_path in test_autoconfig)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two 💤 backport-v3.7.x on-merge: backport to v3.7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants