Backport PR #2479: bugfix for viewer rename when viewer ID is differe… #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmorris3
requested review from
rosteen,
javerbukh,
pllim,
kecnry,
haticekaratay and
cshanahan1
as code owners
kecnry
approved these changes
Sep 27, 2023
|
Hang on... is the change log in the right section? Something seems off since the other entry above it was milestoned in 3.6.x |
|
@kecnry I was also confused when I cherry-picked, because there was no unreleased section at the top. Should I create the headings for an unreleased 3.7.1 section? |
|
Yes, please! Looks like it should go at the very top of the change log above 3.7 and mirror the one on main. Thanks! |
bmorris3
force-pushed
the
auto-backport-of-pr-2479-on-v3.7.x
branch
from
cb547d8 to
df1207e
Compare
… ID is different from reference name
bmorris3
force-pushed
the
auto-backport-of-pr-2479-on-v3.7.x
branch
from
df1207e to
469172d
Compare
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
pllim
reviewed
Sep 27, 2023
| @@ -1,3 +1,27 @@ | |||
| 3.7.1 (unreleased) | |||
There was a problem hiding this comment.
Interesting. I thought @cshanahan1 added this after releasing 3.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #2479.
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.