Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #2485 on branch v3.7.x (BUG: Handle incompatible Specviz flux unit) #2492

Conversation

meeseeksmachine
Copy link

Backport PR #2485: BUG: Handle incompatible Specviz flux unit

@lumberbot-app lumberbot-app bot added this to the 3.7.1 milestone Oct 4, 2023
@lumberbot-app lumberbot-app bot added bug Something isn't working specviz Ready for final review 💤 backport-v3.7.x on-merge: backport to v3.7.x labels Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
jdaviz/app.py 85.21% <100.00%> (+0.03%) ⬆️
jdaviz/configs/specviz/plugins/viewers.py 84.17% <100.00%> (+0.57%) ⬆️
jdaviz/configs/specviz/tests/test_helper.py 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@pllim
Copy link
Contributor

pllim commented Oct 4, 2023

devdeps failure is unrelated and will be fixed by pandas-dev/pandas#55397

@pllim pllim merged commit 1d43a4a into spacetelescope:v3.7.x Oct 4, 2023
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ready for final review specviz 💤 backport-v3.7.x on-merge: backport to v3.7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants