Remove deprecated methods and arguments. #2578
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2578 +/- ##
==========================================
+ Coverage 90.82% 91.22% +0.39%
==========================================
Files 160 160
Lines 19526 19434 -92
==========================================
- Hits 17735 17729 -6
+ Misses 1791 1705 -86 ☔ View full report in Codecov by Sentry. |
rosteen
requested review from
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay and
cshanahan1
as code owners
CHANGES.rst
Outdated
| @@ -53,6 +53,8 @@ Specviz2d | |||
| API Changes | |||
| ----------- | |||
|
|
|||
| - Removed some previously deprecated methods and arguments. [#2578] | |||
There was a problem hiding this comment.
This needs to be more specific. User reading this change log entry needs to know exactly what was removed without having to read the diff here.
There was a problem hiding this comment.
There can even be multiple entries pointing to the same PR, as you see fit. For example, the wording can be something like this for one of them:
- Deprecated ``app.get_data_from_viewer`` is removed. Use ``viz_helper.get_data`` method instead. [#2578]There was a problem hiding this comment.
Done - I left out the show_continuum_marks deprecation, since I think that was solely an internal thing, but I can add it for completeness if anyone thinks we need to.
There was a problem hiding this comment.
Yeah, no need to mention things users are not using directly. Thanks!
* Remove deprecated methods from app.py * Remove more deprecations * Also remove this from user_api * Add changelog * More detailed changelog
This removes some stuff that was deprecated in 3.6, as well as something that's been hanging around deprecated since 3.1, in preparation for the 3.8 release.