-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spinner while stretch histogram data updating #2644
Conversation
d425cf1
to
9102864
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2644 +/- ##
==========================================
- Coverage 91.52% 91.52% -0.01%
==========================================
Files 161 161
Lines 19989 19995 +6
==========================================
+ Hits 18295 18300 +5
- Misses 1694 1695 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I saw it but I can't be sure. It comes and goes too fast. I saw the histogram blink and what I thought is part of a spinner for a split second.
Tested with a very big image and it worked really well. Thank you! |
And now I broke it... :( I will try to reproduce the problem and see if it is just a glitch or an actual problem. |
Ok, the problem is with the toggle "limit histogram to current zoom limits". When toggling it, the spinner is just a flash, but the histogram is taking a longer time to settle. |
I think I managed to fix the main issue as well as the flickering spinner sometimes seen for updates that are immediately skipped. Sometimes though the image viewer seems to process its update before the callback is sent to the stretch histogram, resulting in a "delayed" start of the spinner. I'm not sure there is much we can do about these cases. But the spinner should show whenever the histogram itself is processing an update. Here is what I currently see on my end. Screen.Recording.2024-01-03.at.3.52.07.PM.mov |
Works on my end too! Thank you for fixing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also working for me when data is first loaded and when the zoom is updated and the histogram is limited to said zoom!
Description
This pull request implements a spinner showing when the data for the stretch histogram is updating.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.