Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix top app bar style to align in notebook, popout, and mast #2648

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jan 5, 2024

Description

This pull request implements a minor styling tweak so that the app top-bar aligns with the rest of the app across notebook/lab/popout/mast.

Before (look at 1 pixel white space in the popout to the left and right of the top toolbar):
Screen Shot 2024-01-05 at 1 06 49 PM

After:

Screen Shot 2024-01-05 at 1 07 00 PM

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added UI/UX😍 trivial Only needs one approval instead of two labels Jan 5, 2024
@kecnry kecnry added this to the 3.8.2 milestone Jan 5, 2024
@github-actions github-actions bot added the embed Regarding issues with front-end embedding label Jan 5, 2024
@kecnry kecnry force-pushed the top-bar-alignment branch from 452a257 to 9f47199 Compare January 5, 2024 18:09
@kecnry kecnry added the 💤backport-v3.8.x on-merge: backport to v3.8.x label Jan 5, 2024
@kecnry kecnry marked this pull request as ready for review January 5, 2024 18:10
@kecnry kecnry force-pushed the top-bar-alignment branch from 9f47199 to e511836 Compare January 5, 2024 18:37
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim
Copy link
Contributor

pllim commented Jan 5, 2024

Did HST remote data change again? That's annoying. We can ignore it in this PR unless you want to fix it here.

imviz/tests/test_parser.py::TestParseImage::test_parse_hst_drz - assert (4299, 4219) == (4298, 4220)
  At index 0 diff: 4299 != 4298
  Full diff:
  - (4298, 4220)
  ?     ^    ^^
  + (4299, 4219)
  ?     ^    ^^

@kecnry
Copy link
Member Author

kecnry commented Jan 5, 2024

We can ignore it in this PR unless you want to fix it here.

Let's ignore for now so this PR stays just a small style change. If it seems to persist, we can update separately.

@kecnry
Copy link
Member Author

kecnry commented Jan 5, 2024

@pllim - can you please override and merge with admin if you're ok with ignoring for now?

@pllim pllim merged commit ee4320a into spacetelescope:main Jan 5, 2024
11 of 13 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Jan 5, 2024
@kecnry kecnry deleted the top-bar-alignment branch January 5, 2024 20:54
pllim added a commit that referenced this pull request Jan 5, 2024
…8-on-v3.8.x

Backport PR #2648 on branch v3.8.x (fix top app bar style to align in notebook, popout, and mast)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embed Regarding issues with front-end embedding trivial Only needs one approval instead of two UI/UX😍 💤backport-v3.8.x on-merge: backport to v3.8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants