Hover spectrum with extra axis #2661
Draft
+118
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codestyle Codestyle
github-actions
bot
added
documentation
rosteen
added
💤 enhancement
There was a problem hiding this comment.
Added some suggestions i came up with while working on this, and
bqplot/bqplot#1638
should fix the issue you mentioned.
Comment on lines
+181
to
+182
| self._extra_axis.send_state(["scale", "visible"]) | ||
| self._spectrum_viewer.figure.send_state(["fig_margin", "axes"]) |
There was a problem hiding this comment.
These shouldn't be needed, maybe axes because you mutate them.
| #self._reset_spectrum_viewer_bounds() | ||
| # Fully remove the extra axis rather than just setting to invisible | ||
| if self._extra_axis in self._spectrum_viewer.figure.axes: | ||
| self._spectrum_viewer.figure.axes.remove(self._extra_axis) |
There was a problem hiding this comment.
Suggested change
| self._spectrum_viewer.figure.axes.remove(self._extra_axis) | |
| axes = self._spectrum_viewer.figure.axes.copy() | |
| axes.remove(self._extra_axis) | |
| self._spectrum_viewer.figure.axes = axes |
mutations are not detected
| self._spectrum_viewer = self.viewer.jdaviz_helper.app.get_viewer('spectrum-viewer') | ||
| # Add extra y-axis to show on right hand side of spectrum viewer | ||
| if self._extra_axis not in self._spectrum_viewer.figure.axes: | ||
| self._spectrum_viewer.figure.axes.append(self._extra_axis) |
There was a problem hiding this comment.
Suggested change
| self._spectrum_viewer.figure.axes.append(self._extra_axis) | |
| self._spectrum_viewer.figure.axes = [*self._spectrum_viewer.figure.axes, self._extra_axis] |
mutations are not detected
| self._mark.visible = True | ||
| y_values = spectrum.flux[x, y, :] | ||
| if np.all(np.isnan(y_values)): | ||
| self._mark.visible = False |
There was a problem hiding this comment.
While trying to reproduce the bug in bqplot I noticed this resulted in my axis not being visible most of the time, maybe the test in the line above is faulty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #2647 that would overlay the preview spectrum on whatever the current zoom is, with an additional y-axis on the right to show the flux of the preview spectrum. Currently blocked by a potential bqplot bug, where the axis tick values are not updating when the axis scale updates.