Aperture validate after selection

[kecnry]

Description

This pull request allows non-apertures as choices in subset dropdowns for aperture photometry and spectral extraction and validates them during selection (or on a change to the underlying subset) with the following behavior:

• aperture photometry's aperture: only allow apertures (no composite, no annulus) and disable the compute button when not valid
• aperture photometry's background: allow any subset (in the future if we implement active sections, highlighting will not be done for non-apertures)
• spectral extraction's aperture: non-apertures disable wavelength dependence (for aperture and background) and subpixel support, with in-plugin warnings
• spectral extraction's background: non-apertures disable wavelength dependence (background only) and subpixel support, with in-plugin warnings

TODO:

• raise errors in compute methods, when necessary (including batch aper phot)
• test/update multiselect support
• test coverage

Screen.Recording.2024-01-31.at.1.43.40.PM.mov

Screen.Recording.2024-01-31.at.1.52.54.PM.mov

Screen.Recording.2024-01-31.at.2.09.39.PM.mov

Change log entry

• Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
  list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
  should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

[codecov]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (9373a9e) 90.91% compared to head (acd2d37) 90.89%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
jdaviz/core/template_mixin.py	90.24%	4 Missing ⚠️
...imviz/plugins/aper_phot_simple/aper_phot_simple.py	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2684      +/-   ##
==========================================
- Coverage   90.91%   90.89%   -0.02%     
==========================================
  Files         163      163              
  Lines       21348    21387      +39     
==========================================
+ Hits        19408    19440      +32     
- Misses       1940     1947       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pllim]

I cannot tell which is better. But we can also just grab the 3rd result and not bother with magic underscores.

Suggested change

	_, _, validity = self.aperture._get_mark_coords_and_validate(selected=aperture)
	validity = self.aperture._get_mark_coords_and_validate(selected=aperture)[2]

[kecnry]

I find the underscores to be more readable myself 🤷‍♂️

[javerbukh]

Can this be removed?

[kecnry]

I could rewrite it as a comment, but do think we want something here so that we don't accidentally reintroduce it (since it feels like this should be there)

[javerbukh]

Changing the subset leads to the results you detail in the description, so LGTM, thanks!

[cshanahan1]

Can the snackbar message that is triggered when you try to select a composite subset be avoided?

'Failed to extract Subset 1: AttributeError("'OrState' object has no attribute 'roi'")'

[kecnry]

Can the snackbar message that is triggered when you try to select a composite subset be avoided?

Not easily since its hard to predict the order that the observes will be evaluated. We could refactor the logic, but I also think the extra warning that an input is unsupported doesn't hurt?

[cshanahan1]

This also works as intended for me, approving