Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cubeviz spectral extraction to ignore NaNs by masking them out #2737

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Mar 1, 2024

Description

This pull request is to address problem of extracted spectrum being NaN when cube has NaN.

I cannot find option to do this upstream in astropy.nddata. Example code upstream: https://github.com/astropy/astropy/blob/47a8dac8f1dab6ce592be6048f70140adead4e1d/astropy/nddata/mixins/ndarithmetic.py#L633-L634

This is also a problem in v3.8.x but direct backport is probably tough with the recent refactoring. If you really want to backport, please change the milestone and set backport label.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

pllim added 2 commits March 1, 2024 10:26
that would fail because it is an active bug
@pllim pllim added the bug Something isn't working label Mar 1, 2024
@pllim pllim added this to the 3.9 milestone Mar 1, 2024
@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels Mar 1, 2024
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in for now and we can always remove it if we get a "proper" fix upstream. Thanks for the quick fix!

Copy link
Contributor

@gibsongreen gibsongreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@pllim pllim merged commit abb3864 into spacetelescope:main Mar 5, 2024
19 of 20 checks passed
@pllim pllim deleted the cube-collapse-nan-desuka branch March 5, 2024 14:24
@pllim
Copy link
Contributor Author

pllim commented Mar 5, 2024

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cubeviz plugin Label for plugins common to multiple configurations Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants