-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export plugin filters #2780
Export plugin filters #2780
Conversation
* do not require being a layer in a viewer * add a filter for requiring to be from a plugin, and update language in UI * cleanup implementation of parent/child layer filters to avoid conflict with new default filters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2780 +/- ##
==========================================
+ Coverage 88.72% 88.81% +0.09%
==========================================
Files 110 110
Lines 16353 16433 +80
==========================================
+ Hits 14509 14595 +86
+ Misses 1844 1838 -6 ☔ View full report in Codecov by Sentry. |
<v-row> | ||
<span class="v-messages v-messages__message text--secondary">Export viewer plot as an image.</span> | ||
</v-row> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you missed the Tables section, I think that should also have a caption like this for consistency. Other than that, this PR looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! Tested across different viz and works great!
Description
This pull request fixes the availability of plugin products being available to export from the export plugin if not added to the viewer by removing the default
layer_in_viewer
filter on the dataset component. This also:Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.