Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export plugin filters #2780

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Apr 2, 2024

Description

This pull request fixes the availability of plugin products being available to export from the export plugin if not added to the viewer by removing the default layer_in_viewer filter on the dataset component. This also:

  • excludes non-plugin data via a filter (to be debated if this is better or worse than the messages)
  • excludes spectral subsets via a filter
  • adds language to the sections of the export plugin which includes explanations of what is supported, hopefully to avoid confusion

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

kecnry added 2 commits April 2, 2024 13:32
* do not require being a layer in a viewer
* add a filter for requiring to be from a plugin, and update language in UI
* cleanup implementation of parent/child layer filters to avoid conflict with new default filters
@kecnry kecnry added this to the 3.9 milestone Apr 2, 2024
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.81%. Comparing base (f1ba4a6) to head (0148b76).
Report is 16 commits behind head on main.

Files Patch % Lines
jdaviz/core/template_mixin.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2780      +/-   ##
==========================================
+ Coverage   88.72%   88.81%   +0.09%     
==========================================
  Files         110      110              
  Lines       16353    16433      +80     
==========================================
+ Hits        14509    14595      +86     
+ Misses       1844     1838       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry marked this pull request as ready for review April 2, 2024 18:55
Comment on lines +16 to +18
<v-row>
<span class="v-messages v-messages__message text--secondary">Export viewer plot as an image.</span>
</v-row>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you missed the Tables section, I think that should also have a caption like this for consistency. Other than that, this PR looks good.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@haticekaratay haticekaratay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! Tested across different viz and works great!

@kecnry kecnry merged commit 14b3544 into spacetelescope:main Apr 3, 2024
16 checks passed
@kecnry kecnry deleted the export-plg-filters branch April 3, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin Label for plugins common to multiple configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants