Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in vue file affecting plugin table format #2793

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Apr 10, 2024

Description

This pull request fixes #2792.

Note that before this:

  • export should still work, just will be using ecsv by default
  • changing the format would still work from the API, this bug is isolated to the dropdown UI element itself.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 3.9.1 milestone Apr 10, 2024
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Apr 10, 2024
@kecnry kecnry added the bug Something isn't working label Apr 10, 2024
@kecnry kecnry marked this pull request as ready for review April 10, 2024 12:27
@kecnry kecnry added 💤 backport-v3.9.x on-merge: backport to v3.9.x trivial Only needs one approval instead of two labels Apr 10, 2024
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, thanks!

@kecnry kecnry merged commit bf6aaa2 into spacetelescope:main Apr 10, 2024
24 of 25 checks passed
@kecnry kecnry deleted the fix-plugin-table-format branch April 10, 2024 12:59
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Apr 10, 2024
kecnry added a commit that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two 💤 backport-v3.9.x on-merge: backport to v3.9.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] No formats listed for Aperture Photometry table export
2 participants