Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #2791 on branch v3.9.x (feat: stop jdaviz/voila when the browser window closes) #2799

Conversation

meeseeksmachine
Copy link

Backport PR #2791: feat: stop jdaviz/voila when the browser window closes

@lumberbot-app lumberbot-app bot added this to the 3.9.1 milestone Apr 12, 2024
@lumberbot-app lumberbot-app bot added the bug Something isn't working label Apr 12, 2024
@lumberbot-app lumberbot-app bot added the 💤 backport-v3.9.x on-merge: backport to v3.9.x label Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (v3.9.x@4373488). Click here to learn what that means.

Files Patch % Lines
jdaviz/cli.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             v3.9.x    #2799   +/-   ##
=========================================
  Coverage          ?   88.71%           
=========================================
  Files             ?      110           
  Lines             ?    16547           
  Branches          ?        0           
=========================================
  Hits              ?    14679           
  Misses            ?     1868           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry merged commit e9ea036 into spacetelescope:v3.9.x Apr 12, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 💤 backport-v3.9.x on-merge: backport to v3.9.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants