Temporarily pin glue-core<1.19.0 to fix test failure #2809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosteen
added
no-changelog-entry-needed
rosteen
requested review from
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
pllim
reviewed
Apr 16, 2024
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
pllim
approved these changes
Apr 16, 2024
9 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2809 +/- ##
==========================================
+ Coverage 88.72% 88.79% +0.07%
==========================================
Files 110 110
Lines 16353 16611 +258
==========================================
+ Hits 14509 14750 +241
- Misses 1844 1861 +17 ☔ View full report in Codecov by Sentry. |
|
Hmm I guess devdeps failing makes sense since it isn't fixed yet. |
Yeah, I was about to comment asking if we really wanted to pin an old commit in devdeps or something rather than see it failing (and pass once it's fixed upstream). |
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Apr 16, 2024
…fix test failure
|
I think letting devdeps fail is ok for now. It doesn't block anything and reminds us that upstream is broken. Thanks! |
pllim
added a commit
that referenced
this pull request
Apr 16, 2024
…9-on-v3.9.x Backport PR #2809 on branch v3.9.x (Temporarily pin glue-core<1.19.0 to fix test failure)
2 tasks
pllim
added a commit
to pllim/jdaviz
that referenced
this pull request
Apr 16, 2024
pllim
added a commit
to pllim/jdaviz
that referenced
this pull request
Apr 18, 2024
rosteen
added a commit
to rosteen/jdaviz
that referenced
this pull request
Apr 18, 2024
…2809) * Temporarily pin glue-core<1.19.0 to fix test failure * Update pyproject.toml Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
kecnry
pushed a commit
to kecnry/jdaviz
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2805 for now until we figure out why glue-core broke the test.