Better menu selection labels for spectral lines in line analysis plugin #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosteen
requested review from
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
kecnry
approved these changes
Apr 17, 2024
Comment on lines
252
to
253
| self.line_items = msg.names_rest | ||
| self.line_items = [f"{msg.marks[i].name} {msg.marks[i].rest_value} {msg.marks[i].xunit}" for i in range(len(msg.marks))] # noqa |
There was a problem hiding this comment.
looks like this wasn't exposed API, so shouldn't cause backwards compatibility concerns 🤞
rosteen
force-pushed
the
units-in-redshift-from-centroid
branch
2 times, most recently
from
6786f9e to
10dbd0c
Compare
|
I updated this to only change the displayed text in the menu, since changing the actual value returned as |
kecnry
reviewed
Apr 19, 2024
kecnry
reviewed
Apr 19, 2024
gibsongreen
approved these changes
Apr 19, 2024
Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
Clarify comment
rosteen
force-pushed
the
units-in-redshift-from-centroid
branch
from
a266ea5 to
c28db42
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2816 +/- ##
=======================================
Coverage 88.88% 88.89%
=======================================
Files 111 111
Lines 16983 16986 +3
=======================================
+ Hits 15096 15099 +3
Misses 1887 1887 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the line menu under
Redshift from Centroidshowed the name and originally defined value for the lines, which could have been in different units. Now it shows name + rest value in current units + unit.Before:
Now:
