Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subset plugin: disable update button when no subset selected #2880

Merged
merged 2 commits into from
May 20, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented May 20, 2024

Description

This pull request disables the "update" button when no subset selected.

Screen.Recording.2024-05-20.at.2.45.19.PM.mov

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 3.10.2 milestone May 20, 2024
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label May 20, 2024
@kecnry kecnry marked this pull request as ready for review May 20, 2024 18:47
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.72%. Comparing base (3ac9bfb) to head (8a7174a).
Report is 157 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2880   +/-   ##
=======================================
  Coverage   88.72%   88.72%           
=======================================
  Files         111      111           
  Lines       17102    17102           
=======================================
  Hits        15174    15174           
  Misses       1928     1928           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough!

@pllim pllim added the 💤backport-v3.10.x on-merge: backport to v3.10.x label May 20, 2024
@pllim pllim merged commit b89784c into spacetelescope:main May 20, 2024
26 of 27 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request May 20, 2024
pllim added a commit that referenced this pull request May 20, 2024
…0-on-v3.10.x

Backport PR #2880 on branch v3.10.x (subset plugin: disable update button when no subset selected)
@kecnry kecnry deleted the subset-create-new-no-update branch May 20, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin Label for plugins common to multiple configurations UI/UX😍 💤backport-v3.10.x on-merge: backport to v3.10.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants