About plugin

[pllim]

Description

This pull request is to add a new plugin to let user know which Jdaviz version, etc.

Change log entry

• Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
  list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
  should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

[pllim]

I feel like we don't need user-facing doc since this plugin is purely informational and should be pretty self-explanatory.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.72%. Comparing base (1bce2b2) to head (95eca4c).
Report is 175 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2886      +/-   ##
==========================================
+ Coverage   88.69%   88.72%   +0.02%     
==========================================
  Files         109      111       +2     
  Lines       17047    17081      +34     
==========================================
+ Hits        15120    15155      +35     
+ Misses       1927     1926       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kecnry]

I like it! We can always add other version information or parse and show the changelog directly as potential future follow-ups. Just had two small considerations.

[camipacifici]

Love it!! Great job!
Is it normal that mine complains about 3.10.dev123?

[pllim]

Is it normal that mine complains about 3.10.dev123?

No, but it is also not a problem with the plugin. Whoever released 3.10.0 didn't tag a 3.11.dev. A dev tag is needed when we release from a release branch and not main. Though by now, should we just tag a 4.0.dev, @kecnry ?

[pllim]

I just tagged a v3.11.dev if you git pull upstream --tags and re-install, you should now see a 3.11.dev29+g930125f4. Please do that and see if the PyPI warning goes away for you. Thanks!

[camipacifici]

Does not complain anymore!
I am not a reviewer but you can consider this an approval.

[pllim]

I think @gibsongreen said he was reviewing this. Maybe I should wait for his approval too.

[rosteen]

Cool feature! Approved, your choice to accept my suggestion or not.

[gibsongreen]

I really like this addition to GUI, nice design and very useful, great work!

Just one consideration, I know the plugin is titled About, and it might be overkill since we have the documentation link elsewhere in the GUI, but I could see first time users finding the link in this plugin beneficial.

Also, love thehe branch name 😌

[pllim]

For full disclosure, this also introduces requests as required dependency, but it is already pulled in by astroquery that is already required, so does not matter in the end.