Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin tray open on show #2892

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

javerbukh
Copy link
Contributor

Description

This pull request sets the plugin tray to be open by default when the application is shown.

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added this to the 4.0 milestone May 23, 2024
@pllim
Copy link
Contributor

pllim commented May 23, 2024

I cannot decide if we need a change log or not. The behavior change is very obvious and people might wonder if it is intentional.

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (930125f) to head (4ad336f).
Report is 175 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2892   +/-   ##
=======================================
  Coverage   88.68%   88.69%           
=======================================
  Files         109      109           
  Lines       16999    17047   +48     
=======================================
+ Hits        15076    15120   +44     
- Misses       1923     1927    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog can't hurt (but otherwise can just be tagged to not require the changelog so CI passes). Other than that - the code change probably isn't terribly controversial 😜

@kecnry kecnry added the trivial Only needs one approval instead of two label May 24, 2024
@pllim pllim merged commit 1bce2b2 into spacetelescope:main May 24, 2024
23 checks passed
@javerbukh javerbukh deleted the plugin-tray-open branch May 24, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants