Generalize cube extract

[kecnry]

Description

This pull request generalizes cubeviz's spectral extraction so that it can be re-used by lcviz (photometric extraction of target pixel files) and eventually rampviz. This is milestoned for the 4.0 release, which already contains breaking changes to spectral extraction.

Change log entry

• Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
  list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
  should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

[codecov]

Codecov Report

Attention: Patch coverage is 94.71366% with 12 lines in your changes missing coverage. Please review.

Project coverage is 88.92%. Comparing base (3de1b08) to head (620a102).
Report is 150 commits behind head on main.

Files with missing lines	Patch %	Lines
jdaviz/configs/cubeviz/plugins/mixins.py	89.28%	9 Missing ⚠️
...plugins/spectral_extraction/spectral_extraction.py	97.67%	2 Missing ⚠️
jdaviz/core/template_mixin.py	94.73%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2939      +/-   ##
==========================================
+ Coverage   88.91%   88.92%   +0.01%     
==========================================
  Files         111      112       +1     
  Lines       17365    17396      +31     
==========================================
+ Hits        15440    15470      +30     
- Misses       1925     1926       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rosteen]

One minor suggestion about some disabled message text, but other than that I think this looks good - less complicated that the diff suggested, mostly just moving things around and renaming.

[bmorris3]

Some superficial comments for readability.

[kecnry]

@bmorris3 / @rosteen - added a few more commits since your last reviews if you want to re-review (should be able to filter the diff to just the last ~6 commits)

@bmorris3 - addressed your comments. I haven't touched renaming background or wavelength-dependent related methods and attributes that don't need to be used for lcviz (wavelength_dependent, bg_wavelength_dependent, bg_spec_per_spaxel, bg_spec_add_results, extract_bg_spectrum) - but will rampviz need access to these and maybe we should generalize them (either here or as a separate effort before they get released in 4.0)?

[rosteen]

I think it looks ok, my approval can stand.

[bmorris3]

Thanks @kecnry, looks good 👌🏻

[bmorris3]

I've tested it, and of course it is less performant – but it's the difference between 40 nanoseconds for the original and 150 ns for my suggestion. I'm not sure anyone will notice. 😉