Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delay callback when calling previous zoom #2949

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jul 9, 2024

Description

This pull request prevents the previous zoom tool from updating the image zoom 4 times.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added bug Something isn't working performance Performance related labels Jul 9, 2024
@kecnry kecnry added this to the 3.10.3 milestone Jul 9, 2024
@kecnry kecnry added the 💤backport-v3.10.x on-merge: backport to v3.10.x label Jul 9, 2024
@kecnry kecnry force-pushed the prev-zoom-delay-callback branch from 53f0838 to 7b907ca Compare July 9, 2024 17:53
@kecnry kecnry added the trivial Only needs one approval instead of two label Jul 9, 2024
@kecnry kecnry marked this pull request as ready for review July 9, 2024 17:54
Copy link
Contributor

@haticekaratay haticekaratay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks straightforward.

* will do one update instead of 4
@kecnry kecnry force-pushed the prev-zoom-delay-callback branch from 7b907ca to ed2cce3 Compare July 11, 2024 14:22
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (18bb83e) to head (ed2cce3).
Report is 154 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2949   +/-   ##
=======================================
  Coverage   88.79%   88.80%           
=======================================
  Files         111      111           
  Lines       17245    17246    +1     
=======================================
+ Hits        15313    15315    +2     
+ Misses       1932     1931    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry merged commit 73e54d0 into spacetelescope:main Jul 11, 2024
19 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Jul 11, 2024
@kecnry kecnry deleted the prev-zoom-delay-callback branch July 11, 2024 15:05
kecnry added a commit that referenced this pull request Jul 11, 2024
Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working performance Performance related trivial Only needs one approval instead of two 💤backport-v3.10.x on-merge: backport to v3.10.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants