-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export plugin: hide all serverside-saving sections on MAST #3096
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3096 +/- ##
=======================================
Coverage 88.73% 88.73%
=======================================
Files 111 111
Lines 17271 17274 +3
=======================================
+ Hits 15325 15328 +3
Misses 1946 1946 ☔ View full report in Codecov by Sentry. |
There is conflict in change log. Also probably need approval from @havok2063 ? |
Yep, I'll rebase before merge (shouldn't hold up reviews though). I don't think we need a review from @havok2063 (although he's welcome to) - this is the same machinery we've used in the past and they already have implemented on their end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks like code. Thanks!
4954fbb
to
5560972
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed this PR on Friday but didn't actually submit the review 🤦🏻♂️
This makes sense, thanks!
Description
This pull request uses the existing
server_is_remote
app-wide setting to hide the sections in the export plugin that would result in saving a file serverside (i.e. not through the file dialog).To test: set
server_is_remote=False
in the config yaml file or setviz.plugins['Export']._obj.serverside_enabled=False
.Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.