Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export plugin: hide all serverside-saving sections on MAST #3096

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jul 17, 2024

Description

This pull request uses the existing server_is_remote app-wide setting to hide the sections in the export plugin that would result in saving a file serverside (i.e. not through the file dialog).

To test: set server_is_remote=False in the config yaml file or set viz.plugins['Export']._obj.serverside_enabled=False.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added the bug Something isn't working label Jul 17, 2024
@kecnry kecnry added this to the 3.10.3 milestone Jul 17, 2024
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Jul 17, 2024
@kecnry kecnry added the 💤backport-v3.10.x on-merge: backport to v3.10.x label Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (5c92eae) to head (5560972).
Report is 151 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3096   +/-   ##
=======================================
  Coverage   88.73%   88.73%           
=======================================
  Files         111      111           
  Lines       17271    17274    +3     
=======================================
+ Hits        15325    15328    +3     
  Misses       1946     1946           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry marked this pull request as ready for review July 18, 2024 13:38
@pllim
Copy link
Contributor

pllim commented Jul 18, 2024

There is conflict in change log.

Also probably need approval from @havok2063 ?

@kecnry
Copy link
Member Author

kecnry commented Jul 18, 2024

There is conflict in change log

Yep, I'll rebase before merge (shouldn't hold up reviews though). I don't think we need a review from @havok2063 (although he's welcome to) - this is the same machinery we've used in the past and they already have implemented on their end.

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks like code. Thanks!

@kecnry kecnry force-pushed the mast-export-rules branch from 4954fbb to 5560972 Compare July 22, 2024 12:34
Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR on Friday but didn't actually submit the review 🤦🏻‍♂️

This makes sense, thanks!

@kecnry kecnry merged commit 3279bcf into spacetelescope:main Jul 22, 2024
18 of 19 checks passed
@kecnry kecnry deleted the mast-export-rules branch July 22, 2024 14:52

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin Label for plugins common to multiple configurations Ready for final review 💤backport-v3.10.x on-merge: backport to v3.10.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants