-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JWST L1 ramp parser for Rampviz #3148
Conversation
14cfc61
to
566aebb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3148 +/- ##
==========================================
+ Coverage 87.21% 88.42% +1.20%
==========================================
Files 122 122
Lines 18260 18264 +4
==========================================
+ Hits 15926 16150 +224
+ Misses 2334 2114 -220 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
# swap axes per the conventions of ramp cubes | ||
# (group axis comes first) and the default in | ||
# rampviz (group axis expected last) | ||
return np.swapaxes(x, 0, -1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you ever plan to support beyond Roman vs JWST? Maybe instead of swapping, should hardcode the index by telescope name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not in the plans for now. If they become part of the plan, we'd need to build a parser for those "non-standard" cubes anyway, so I'll keep it like this for now.
1717d47
to
1b01efc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, and more importantly I ran the notebook and it works! The only thing I might suggest is splitting the imports in the concept notebook into a separate cell, so you don't have to download the Roman file from Box if you just want to run the JWST example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Follow up after #3120 adding support for JWST L1 ramps.
The only major difference between JWST ramp files (any instrument) and Roman WFI is that JWST bundles time-series observations with multiple integrations into one 4D array of dimensions (integrations, groups, x-pixel, y-pixel), whereas Roman only ships single integrations in a 3D array.
This PR adds a parser for JWST Level 1 data products as fits files or
Level1bModel
models. By default, rampviz will load the zeroth integration, and specific integrations can be selected with, e.g.:Since this PR adds support for JWST, without the need for the optional Roman dependencies, the project code coverage test here is more useful than in #3120.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.