convert flux cubes to per-square-pixel surface brightness cubes

[cshanahan1]

This PR implements support of per-pixel surface brightness cubes. Cubes loaded in flux units will be loaded as flux per square pixel surface brightness cubes. Cubes loaded directly in flux/pix2 are now supported as well.

This also fixes an issue with units in moment maps that was required for this work (may overlap some with #3116)

Another issue with batch mode photometry not showing units in the plugin is fixed by this as well

Also adds some improvement of support for cubes in counts

[kecnry]

Loading a flux cube, setting the flux or sb switch in unit conversion to surface brightness, and then changing flux unit raises a bunch of errors, likely similar situations as #3139.

[cshanahan1]

That seems to be working fine for me, interesting. I'll try to reproduce the errors

[kecnry]

I was using:

from jdaviz.conftest import _create_spectrum1d_cube_with_fluxunit
data = _create_spectrum1d_cube_with_fluxunit(fluxunit=u.Jy, shape=(2,2,4), with_uncerts=True)
cubeviz.load_data(data)

[rosteen]

Would you rebase to main and fix the conflicts, please?

[cshanahan1]

I was using:

from jdaviz.conftest import _create_spectrum1d_cube_with_fluxunit
data = _create_spectrum1d_cube_with_fluxunit(fluxunit=u.Jy, shape=(2,2,4), with_uncerts=True)
cubeviz.load_data(data)

This doesn't give me any errors after loading that cube:
uc = cubeviz_helper.plugins['Unit Conversion']._obj
setting to SB
uc.flux_or_sb.selected = 'Surface Brightness'
and changing flux unit
uc.flux_unit.selected = 'Jy'

it also works in the UI. Was there some other way to trigger this error?

[kecnry]

here's a full example to reproduce with the current branch.

from jdaviz import Cubeviz
from jdaviz.conftest import _create_spectrum1d_cube_with_fluxunit
from astropy import units as u
data = _create_spectrum1d_cube_with_fluxunit(fluxunit=u.Jy, shape=(2,2,4), with_uncerts=True)
cubeviz = Cubeviz()
cubeviz.load_data(data)
cubeviz.show()

uc = cubeviz.plugins['Unit Conversion']
uc.open_in_tray()
uc.flux_or_sb = 'Surface Brightness' # at this point mouseover in the spectrum viewer is broken, but that can probably be a follow-up ticket
uc.flux_unit = 'MJy'
uc.flux_or_sb = 'Flux'

[pllim]

Partial review. Will continue later.

Note to self: test_cubeviz_aperphot_cube_sr_and_pix2

[pllim]

I think I will stop here. Looking like you are pushing commits while I am reviewing. I don't want to end up reviewing outdated content.

[rosteen]

Skipped tests that needed #3190 + this are unskipped and passing, approved. Thanks for all the work on this!

[pllim]

I added 2 follow up items to #3192 . My one comment about the import is not that important since CI is passing. So approving.

Feel free to merge if you don't want to address that comment or after you address it.

Thanks!