Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply api-hints styling to aperture_method in spectral extraction #3231

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Oct 18, 2024

Description

This pull request fixes a missing style class added for API hints to the aperture_method entry in spectral extraction.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added UI/UX😍 trivial Only needs one approval instead of two 💤backport-v4.0.x on-merge: backport to v4.0.x labels Oct 18, 2024
@kecnry kecnry added this to the 4.0.1 milestone Oct 18, 2024
@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels Oct 18, 2024
@kecnry kecnry marked this pull request as ready for review October 18, 2024 16:21
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.62%. Comparing base (9a1fe09) to head (5e75946).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3231   +/-   ##
=======================================
  Coverage   88.62%   88.62%           
=======================================
  Files         125      125           
  Lines       18775    18775           
=======================================
  Hits        16639    16639           
  Misses       2136     2136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry merged commit 19242dd into spacetelescope:main Oct 18, 2024
18 of 19 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Oct 18, 2024
@kecnry kecnry deleted the missing-api-hints-styling branch October 18, 2024 16:43
kecnry added a commit that referenced this pull request Oct 18, 2024
…tral extraction (#3233)

Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two UI/UX😍 💤backport-v4.0.x on-merge: backport to v4.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants