BUG: Fix radial profile fitting when NaN in data #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calculations for radial profile fit
pllim
added
bug
github-actions
bot
added
imviz
plugin
pllim
commented
Oct 22, 2024
| phot_plugin.vue_do_aper_phot() | ||
| tbl = imviz_helper.get_aperture_photometry_results() | ||
|
|
||
| assert phot_plugin.result_failed_msg == '' |
There was a problem hiding this comment.
This fails as such on main without this patch:
> assert phot_plugin.result_failed_msg == ''
E assert "Aperture pho...infeasible.')" == ''
E
E + Aperture photometry failed: ValueError('`x0` is infeasible.')
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3246 +/- ##
=======================================
Coverage 88.63% 88.63%
=======================================
Files 125 125
Lines 18779 18779
=======================================
Hits 16644 16644
Misses 2135 2135 ☔ View full report in Codecov by Sentry. |
cshanahan1
approved these changes
Oct 24, 2024
kecnry
approved these changes
Oct 25, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Oct 25, 2024
|
Thanks for reviews! |
pllim
added a commit
that referenced
this pull request
Oct 25, 2024
…6-on-v4.0.x Backport PR #3246 on branch v4.0.x (BUG: Fix radial profile fitting when NaN in data)
rosteen
pushed a commit
that referenced
this pull request
Oct 29, 2024
* BUG: Exclude NaNs in max and mean calculations for radial profile fit * TST: Add test that fails without this patch * Add change log * move import up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to address profile fitting crashing when NaN is within aperture data.
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.